Skip to content

improve checkbox theme and add missing properties #15533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

didimmova
Copy link
Contributor

Closes #15495

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@didimmova didimmova requested a review from simeonoff March 18, 2025 09:56
@didimmova didimmova linked an issue Mar 18, 2025 that may be closed by this pull request
skrustev and others added 23 commits March 25, 2025 16:00
…used by the user and flip the gradient for star and end to follow the progressbar progress direction (#15560)
fix(query-builder): refactor drag and drop test - master
* refactor(query builder): fix fluent chip keyboard drag ghost text color

* refactor(query-builder): use the correct text color variable and reset the hover fro indigo border
* fix(query-builder): add test for mutated fields collection

* fix(query-builder): prevent changing fields collection

* fix(query-builder): fix Advanced filtering failing tests
…s-add

Additional fix for enabling filtering expressions to generate as classes in React.
…15658)

* feat(hierarchical-grid): add parentRowData to IGridCreatedEventArgs

* chore(*): Always include parentRowData in the arguments

* chore(*): clean up leftover

---------

Co-authored-by: Hristo <[email protected]>
* fix(*): adding random function for unsecure context #15461

* chore(*): applying changes from review

* fix(test): adding unit tests for new random func
desig9stein and others added 14 commits April 8, 2025 15:21
#15556)

* feat(GridBase): Apply spec for server-side rendering for relative grid sizes.

* chore(*): Apply width=100% only for ssr.

* chore(*): Adjust check so that data is omitted only for % size in ssr.
* fix(list): focus styles

* refactor(list-sample): add panning option

---------

Co-authored-by: Simeon Simeonoff <[email protected]>
* feat(h-grid): Enhanced the advanced filtering dialog to support filtering in the nested levels.
…15421)

* fix(splitter): Sizing panes corectly with minSize and the browser is shrinked

* fix(tests): providing bg locale for date-util test spec

---------

Co-authored-by: Ivan Kitanov <[email protected]>
Co-authored-by: Konstantin Dinev <[email protected]>
Co-authored-by: Vasya Kacheshmarova <[email protected]>
Co-authored-by: Stamen Stoychev <[email protected]>
Copy link
Collaborator

@SisIvanova SisIvanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the disabled/disabled indeterminate states in all themes.
Screenshot 2025-04-16 at 4 52 03 PM
Screenshot 2025-04-16 at 4 57 31 PM

@SisIvanova SisIvanova added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Apr 16, 2025
@didimmova didimmova requested a review from SisIvanova April 17, 2025 06:51
@SisIvanova SisIvanova added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Apr 17, 2025
@simeonoff simeonoff merged commit 7fcee0e into didimmova/improve-component-themes Apr 17, 2025
@simeonoff simeonoff deleted the didimmova/improve-checkbox-theme branch April 17, 2025 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
checkbox ✨ themes ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Checkbox Theme